[llvm] r210920 - Finishing touch for the std::error_code transition.

[Hal Finkel]

----- Original Message -----
> From: "Chandler Carruth" <chandlerc at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "Rafael Espindola" <rafael.espindola at gmail.com>, "Commit Messages and Patches for LLVM"
> <llvm-commits at cs.uiuc.edu>, "Richard Smith" <richard at metafoo.co.uk>
> Sent: Friday, June 13, 2014 12:46:09 PM
> Subject: Re: [llvm] r210920 - Finishing touch for the std::error_code transition.
> 
> 
> 
> 
> 
> On Fri, Jun 13, 2014 at 6:42 PM, Hal Finkel < hfinkel at anl.gov >
> wrote:
> 
> 
> 
> > +// * Some implementations define fewer names than others. This
> > header has
> > +// the intersection of all the ones we support.
> 
> I don't understand how this problem is helped by this header, if it
> hurt us previously, and why it mattered otherwise. Can you please
> explain?
> 
> The only enums available now are the ones we wrote into this header
> file. So if you use another one, you *definitely* get a compiler
> error. Otherwise, you might add a use of some other enum, and it
> would compile for you, but break for others.

Hrmm... okay, but this does not solve that problem, it just localizes it to this header. That being the case, why are we using the std:: names at all? Can't we use some kind of SFINAE-enhanced static table for make_error_code?

Thanks again,
Hal

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory