[llvm] r210641 - Create macro INITIALIZE_TM_PASS.

Chandler Carruth chandlerc at google.com
Fri Jun 13 09:11:28 PDT 2014


On Fri, Jun 13, 2014 at 5:03 PM, Jiangning Liu <liujiangning1 at gmail.com>
wrote:

> Hi Chandler,
>
> Attached patch is fix this issue. OK to commit?
>

Mostly...

I don't really understand the changes in test/CodeGen/ARM/global-merge-1.ll
though. You seem to be removing a bunch of tests (perhaps in addition to
merging in the test from test/Transforms/GlobalMerge/ARM/...) which doesn't
make sense to me.

Otherwise everything seems good.


> BTW, should we also have a regression test to check the libraries'
> dependency?
>

Not sure of an easy way to do this, but maybe its worthwhile.


> I didn't expect this is blocking others' build. Sorry about that!
>

It's fine, it didn't break any build bots, etc. Just some uses of LLVM that
assumed the scalar optimization library didn't have these dependencies were
broken.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140613/15b6e3c5/attachment.html>


More information about the llvm-commits mailing list