[polly] Little refactoring
Johannes Doerfert
jdoerfert at codeaurora.org
Fri Jun 13 09:08:59 PDT 2014
>> On 06/13/2014 01:27 AM, Johannes Doerfert wrote:
>> > Refactoring:
>> >
>> > - Refactored reoccurring if cascade
>>
>> LGTM.
One more to commit.
>> > - C++11 iterators & range loops.
>>
>> I'm not sure what others think, but I don't like range loops that use
auto for the element type. It is a MemoryAccess, why not call it that way
;-).
I can do both [As long as I can use range loops ;)]. Is there a llvm
guideline? If not let's define one for us.
>> Apart from that, LGTM.
Once the above is cleared, one more to commit.
>> Cheers,
>> Andreas
--
Johannes Doerfert
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
More information about the llvm-commits
mailing list