[llvm] r210766 - CMake: don't install the internal config.h header

Alp Toker alp at nuanti.com
Thu Jun 12 13:40:42 PDT 2014


On 12/06/2014 23:37, Reid Kleckner wrote:
> Does the CMake standalone build work with this change?  IDE users 
> typically use this to have separate projects for Clang and LLVM.  I 
> believe Clang is built by pointing at an LLVM install directory.

Yes, it should work fine. That's what all the header cleanups were about.

If there's any problem, copy me in on the bug as a priority. The 
cleanups make it easy to embed the non-stable LLVM and clang tooling 
interfaces in C++ applications (caveat emptor, stability is a non-goal 
same as ever). Though I suspect the effort has also helped modules but 
Richard knows the deal there :-)

Alp.

>
>
> On Thu, Jun 12, 2014 at 4:25 AM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>     Author: alp
>     Date: Thu Jun 12 06:25:18 2014
>     New Revision: 210766
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=210766&view=rev
>     Log:
>     CMake: don't install the internal config.h header
>
>     Background:
>     http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/073707.html
>
>     Modified:
>         llvm/trunk/CMakeLists.txt
>
>     Modified: llvm/trunk/CMakeLists.txt
>     URL:
>     http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=210766&r1=210765&r2=210766&view=diff
>     ==============================================================================
>     --- llvm/trunk/CMakeLists.txt (original)
>     +++ llvm/trunk/CMakeLists.txt Thu Jun 12 06:25:18 2014
>     @@ -583,6 +583,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
>          PATTERN "*.inc"
>          # Exclude include/llvm/CMakeFiles/intrinsics_gen.dir, matched
>     by "*.def"
>          PATTERN "CMakeFiles" EXCLUDE
>     +    PATTERN "config.h" EXCLUDE
>          PATTERN ".svn" EXCLUDE
>          )
>      endif()
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list