[PATCH] Some code improvements (no functional change)

[Eric Christopher]

On Thu, Jun 12, 2014 at 8:54 AM, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Thu, Jun 12, 2014 at 4:46 PM, Duncan P. N. Exon Smith
> <dexonsmith at apple.com> wrote:
>>
>> > On 2014 Jun 12, at 08:42, Chandler Carruth <chandlerc at google.com> wrote:
>> >
>> > I'm lacking context sadly. =/
>>
>> Idea is:
>>
>>   - SwapByteOrder takes args by value and returns swapped bytes.
>>   - Some users want to swap in place.
>>   - So, rename SwapByteOrder => getSwappedBytes.
>>   - Then, add swapByteOrder (which takes and modifies a reference).
>
>
> Anyways, to directly answer: this sounds reasonable to me, and if you're
> touching the code I would go ahead and fix the naming convention. The only
> time I really agree with touching code and preserving the old naming
> convention is when there is some huge interface convention that would
> suddenly become inconsistent. The canonical example is IRBuilder.
>

Agreed.

-eric