[PATCH] Remove pimpl class from PassRegistry.

[David Blaikie]

Looks good to me, please commit! (various optional comments, curiosities, etc)

================
Comment at: include/llvm/PassInfo.h:1
@@ +1,2 @@
+//===- llvm/PassInfo.h - Pass Info class ------------------------*- C++ -*-===//
+//
----------------
I take it you had to split this out to resolve a dependency that wasn't exposed when everything was pmpld away?

================
Comment at: include/llvm/PassRegistry.h:61
@@ -39,3 +60,3 @@
 public:
-  PassRegistry() : pImpl(nullptr) { }
+  PassRegistry() { }
   ~PassRegistry();
----------------
You can remove this now that it's got nothing in it.

================
Comment at: lib/IR/PassRegistry.cpp:39
@@ -74,10 +38,3 @@
 
 PassRegistry::~PassRegistry() {
 }
----------------
delete this dtor now that it's not doing anything special?

================
Comment at: lib/IR/PassRegistry.cpp:71
@@ -117,3 +70,3 @@
   
-  if (ShouldFree) Impl->ToFree.push_back(std::unique_ptr<const PassInfo>(&PI));
+  if (ShouldFree) ToFree.push_back(std::unique_ptr<const PassInfo>(&PI));
 }
----------------
Oh dynamically conditional ownership... (not your problem, just me being sad)

http://reviews.llvm.org/D4107