[PATCH] Use loop unrolling pragma metadata in the loop unroller

[Mark Heffernan]

I responded to all the comments via Phabricator over an hour ago, but
Phabricator never sent out the corresponding email :-(  I've verified that
others can see my comment at http://reviews.llvm.org/D4090 so please look
there for my responses and latest patch.

Mark


On Tue, Jun 10, 2014 at 4:02 PM, Eli Bendersky <eliben at google.com> wrote:

> ================
> Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:274
> @@ +273,3 @@
> +    bool HasEnablePragma = HasUnrollEnablePragma(L, Enable);
> +    int PragmaCount;
> +    bool HasCountPragma = HasUnrollCountPragma(L, PragmaCount);
> ----------------
> Move this closer to use
>
> ================
> Comment at: test/Transforms/LoopUnroll/unroll-pragmas.ll:48
> @@ +47,3 @@
> +  %exitcond = icmp eq i64 %indvars.iv.next, 4
> +  br i1 %exitcond, label %for.end, label %for.body, !llvm.loop !1
> +
> ----------------
> IMHO it would be more readable if you placed !1 right after this function.
> I don't think the mdnodes have to be necessarily collected in the bottom.
> Ditto for the rest
>
> http://reviews.llvm.org/D4090
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140611/cac7fd0a/attachment.html>