[PATCH] MergeFunc: Avoid invalid merge of functions using different range metadata

Björn Steinbrink bsteinbr at gmail.com
Wed Jun 11 09:19:18 PDT 2014


Hi Stepan,

my bad, I just always forget that the hashmap contains ComparableFunctions, not just Functions, so I didn't see where to put the list of load instructions.

Just to make sure that I didn't misunderstand you and implement the wrong thing, you want me to go back to the initial patch that removes the merge of such function and fix the tests to ensure that the whole body is retained. And then later once you reworked ComparableFunction, I could go and implement the merge of ranges in a proper way, right?

Thanks!
Björn

PS: No worries about the o-umlaut, I'm used to losing that on the internet ;-)

http://reviews.llvm.org/D4062






More information about the llvm-commits mailing list