[PATCH] Remove support for enabling / disabling multi-threading at runtime.

Alp Toker alp at nuanti.com
Tue Jun 10 12:56:05 PDT 2014


On 10/06/2014 22:46, Zachary Turner wrote:
> Maybe a bug in Phabricator, but for some reason email notifications 
> for this particular issue are no longer being sent out.  So I'm 
> responding here since changes a new revision has been uploaded:
>
> Most recent summary:
> 1) All major review issues addressed
> 2) rnk@ spoke to someone from Apple who said their biggest concern is 
> whether it will have any impact on single-threaded compilation 
> performance.
> 3) Ran tests on MacOSX by compiling sqlite3.c with / without the 
> patch, and saw no noticeable impact on performance, which hopefully 
> satisfies the concern raised in #2
> 4) Change was discussed on LLVMDev prior to initial upload to 
> Phabricator, so some support has been built for this already.  If 
> anyone feels like more is necessary before committing, please speak up.

Patch?

Alp.


>
>
> On Mon, Jun 9, 2014 at 4:27 PM, Zachary Turner <zturner at google.com 
> <mailto:zturner at google.com>> wrote:
>
>     Address review comments.
>
>     http://reviews.llvm.org/D4076
>
>     Files:
>       include/llvm-c/Core.h
>       include/llvm/Support/ManagedStatic.h
>       include/llvm/Support/Threading.h
>       lib/IR/Core.cpp
>       lib/Support/ErrorHandling.cpp
>       lib/Support/ManagedStatic.cpp
>       lib/Support/Threading.cpp
>       lib/Support/Timer.cpp
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list