[PATCH] CodeGen: refactor DwarfException

[Saleem Abdulrasool]

On Tue, Jun 10, 2014 at 10:04 AM, Tim Northover <t.p.northover at gmail.com>
wrote:

> Hi Saleem,
>
> This looks like a very good idea. Just one comment on something that could
> be tidied at the same time...
>

I agree that this is a good time to do this.  Ill do that, since the
uniformity would be nice.


> ================
> Comment at: lib/CodeGen/AsmPrinter/EHStreamer.cpp:33
> @@ +32,3 @@
> +/// How many leading type ids two landing pads have in common.
> +unsigned EHStreamer::SharedTypeIds(const LandingPadInfo *L,
> +                                   const LandingPadInfo *R) {
> ----------------
> It would be a shame to do this mass move and not take the opportunity to
> rename this "sharedTypeIds" to match the LLVM style guide.
>
> Similarly for the other functions here. Most of them seem fairly localised.
>
> http://reviews.llvm.org/D4085
>
>
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140610/4839ae9c/attachment.html>