[PATCH] Fix a bug in the Thumb1 ARM Load/Store optimizer which resulted in the base register reset instruction being incorrectly placed.
Renato Golin
renato.golin at linaro.org
Tue Jun 10 08:48:23 PDT 2014
Hi Morizt,
Apart from the comment, LGTM.
--renato
================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:508
@@ -507,3 +507,3 @@
// non-writeback. Check for this.
- if (Opcode == ARM::tLDRi && isThumb1)
+ if (Opcode == ARM::tLDMIA && isThumb1)
for (unsigned I = 0; I < NumRegs; ++I)
----------------
This change looks odd. Why is the previous case not relevant any more?
http://reviews.llvm.org/D4084
More information about the llvm-commits
mailing list