[patch] opt: Initialize asm printers to avoid DCE

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 10 07:35:12 PDT 2014


Yes, LGTM.

On 10 June 2014 03:46, Tobias Grosser <tobias at grosser.es> wrote:
> On 28/05/2014 00:46, Chandler Carruth wrote:
>>
>> On Tue, May 27, 2014 at 3:36 PM, Tobias Grosser <tobias at grosser.es> wrote:
>>
>>> Right, I believe dumping asm e.g. to do some kind of code-size or
>>> register
>>> allocation auto-tuning might also be interesting. However, many of such
>>> use
>>> case may be more interesting for experiments or debugging that for actual
>>> production work.
>>>
>>> Was this some kind of 'LGTM' or would you like to have further
>>> discussions
>>> on this topic?
>>>
>>
>> This was an LGTM for the idea of keeping the asm printers (and any other
>> useful LLVM libraries for plugins) live and available in the opt binary. I
>> haven't looked at the patch, but I don't really see any risks or downsides
>> to making plugins able to do cool things or even crazy things. If the
>> patch
>> looks good to someone, carry on.
>
>
> Rafael, you looked at this patch. In the context of Chandlers comments and
> no further feedback from Reid, do you think it looks good?
>
> Cheers,
> Tobias
>



More information about the llvm-commits mailing list