[PATCH 03/11] Record a pointer to the AliasSet

[Andreas Simbuerger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 06/10/2014 09:21 AM, Tobias Grosser wrote:
> On 09/06/2014 02:42, Andreas Simbuerger wrote:
>> Instead of taking the pointer of the AliasSet reference we
>> directly retreive a pointer from the AliasSetTracker. This gives
>> us a pointer that should be valid at least until the
>> ScopDetection is destroyed. --- lib/Analysis/ScopDetection.cpp |
>> 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
>> 
>> diff --git a/lib/Analysis/ScopDetection.cpp 
>> b/lib/Analysis/ScopDetection.cpp index cab7af7..fbaf07c 100644 
>> --- a/lib/Analysis/ScopDetection.cpp +++
>> b/lib/Analysis/ScopDetection.cpp @@ -471,8 +471,15 @@ bool 
>> ScopDetection::isValidMemoryAccess(Instruction &Inst, // alias,
>> if -basicaa is not available. They actually do not, but as we
>> can // not proof this without -basicaa we would fail. We disable
>> this check to // not cause irrelevant verification failures. -
>> if (!AS.isMustAlias()) -    return invalid<ReportAlias>(Context,
>> /*Assert=*/true, &Inst, &AS); +  if (!AS.isMustAlias()) { +    //
>> If we want to be able to use this for diagnostics outside of +
>> // ScopDetection, we need to fetch the AliasSet as a pointer as 
>> soon as it +    // is created above. +    AliasSet *ASPtr =
>> Context.AST.getAliasSetForPointerIfExists( +        BaseValue,
>> AliasAnalysis::UnknownSize, +
>> Inst.getMetadata(LLVMContext::MD_tbaa)); +    return
>> invalid<ReportAlias>(Context, /*Assert=*/false, &Inst, ASPtr); +
>> }
> 
> I am slightly confused. Are you saying this will yield another
> pointer than deriving the pointer via '&AS'? Why is this the case?
> Looking at the implementations of getAliasSetForPointer() and 
> getAliasSetForPointerIfExists() both call findAliasSetForPointer(),
> the first returning the plain pointer, the second dereferencing it
> and returning it as reference.


Ah you're right. For some odd reason it fixed a problem in my jit
compiler. However, this is not the case anymore, weird.

The problem here is that the reference is only valid as long as the
DetectionContext is valid. So this means a segfault for any user of
the RejectLog, when he tries to get the debug message.

I wonder how it fixed anything in the first place... I'll come up with
something better. Maybe just unpacking the Values from the AliasSet on
diagnostic object construction.

> 
> Do you have a test case that is fixed by this change?
> 
> Cheers, Tobias
> 

- -- 
Andreas Simbürger
University of Passau - Programming Group
http://www.infosun.fim.uni-passau.de/cl/staff/simbuerger/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJTlu7YAAoJELS7a/6Ti2HYf8AH/05HFmAgFZOWVFGm4PwEtxuk
sdrHYJH8XGiIAQdME41GwirZT5FHaikUTvcDPKZdtqJPQcoj8MuZG1KCo8PIIG7U
zOCe2kE1NjG/PesMlE6EIDiUSsyxgKJyfWzWFfMQZ+VW9g395e2wDR4AGkjbKHEq
693usgO7cROWzPxvzGJJEK3IneEs/w41DiDl5m9GPwor6wUR8sGgm6+ELMQZcniQ
3e0/fNjNA/BuYRg3rr/pcU2i3xztpXrvXCDVW3tvsMs0/60nmPx4qnIATDIOCgoK
zbOpyp7yZhMBedYF4V+Kr2QjoTQ+Yq46OqVcxiFjte4ECbjZw77vTGhn19kekGw=
=CjJv
-----END PGP SIGNATURE-----