[compiler-rt] r210465 - [asan] Remove dependency of tests on runtime library in standalone build.

[Evgeniy Stepanov]

Still, technically tests depend on it.
Please read the code add_lit_target() - you can not have a lit test
target without dependencies, and reasons for that seem valid. Perhaps
we could just add another variant of that function, or an argument to
the existing one, to say that it's ok to have no test dependencies in
the compiler-rt standalone build?

On Tue, Jun 10, 2014 at 12:08 AM, Alexey Samsonov <vonosmas at gmail.com> wrote:
>
> On Mon, Jun 9, 2014 at 4:17 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com>
> wrote:
>>
>> Author: eugenis
>> Date: Mon Jun  9 06:17:37 2014
>> New Revision: 210465
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=210465&view=rev
>> Log:
>> [asan] Remove dependency of tests on runtime library in standalone build.
>>
>> Modified:
>>     compiler-rt/trunk/test/asan/CMakeLists.txt
>>
>> Modified: compiler-rt/trunk/test/asan/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/CMakeLists.txt?rev=210465&r1=210464&r2=210465&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/test/asan/CMakeLists.txt (original)
>> +++ compiler-rt/trunk/test/asan/CMakeLists.txt Mon Jun  9 06:17:37 2014
>> @@ -96,8 +96,10 @@ if(COMPILER_RT_INCLUDE_TESTS)
>>      ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg)
>>  endif()
>>
>> -set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS} asan)
>> -if(NOT COMPILER_RT_STANDALONE_BUILD)
>> +set(ASAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
>> +if(COMPILER_RT_STANDALONE_BUILD)
>> +  list(APPEND ASAN_TEST_DEPS ${LLVM_TOOLS_BINARY_DIR}/FileCheck)
>
>
> Why? In a standalone build FileCheck is just some external binary.
>
>>
>> +else()
>
>
>
>>
>>    list(APPEND ASAN_TEST_DEPS asan)
>>  endif()
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> --
> Alexey Samsonov
> vonosmas at gmail.com