[LNT] r210352 - Fix geometric mean comparison bug introduced in r210123

[Yi Kong]

Author: kongyi
Date: Fri Jun  6 11:07:52 2014
New Revision: 210352

URL: http://llvm.org/viewvc/llvm-project?rev=210352&view=rev
Log:
Fix geometric mean comparison bug introduced in r210123

not_none was not correctly implemented.

Modified:
    lnt/trunk/lnt/server/reporting/analysis.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=210352&r1=210351&r2=210352&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Fri Jun  6 11:07:52 2014
@@ -242,20 +242,14 @@ class RunInfo(object):
     #Smallest possible change we ever look for.
     MIN_VALUE = 0.00001
 
-    @staticmethod
-    def not_none(thing):
-        if thing is None:
-            return True
-        return False
-
     def _extract_values_from_samples(self, run, field):
         """Given a run object, collect values for a particular field."""
 
-        run_samples = filter(self.not_none,
+        run_samples = filter(lambda x: x is not None,
                              [self.sample_map.get((run, test_id))
                               for test_id in self.get_test_ids()])
 
-        run_values = filter(self.not_none,
+        run_values = filter(lambda x: x is not None,
                             [self.aggregation_fn(a[field] + self.MIN_VALUE
                              for a in e if a[field] is not None)
                              for e in run_samples if e])