[PATCH] Emit DWARF3 call frame information when DWARF3+ debug info is requested

David Blaikie dblaikie at gmail.com
Thu Jun 5 13:54:20 PDT 2014


So - is this just correcting the number to reflect the version we're actually emitting? Should we just hardcode it to the higher number, then? 

Are there any other cases of differences between CIE versions other than the one place you fixed in this patch? I'd sort of consider leaving that code to just use "emitIntValue" and assert that the value is small enough, with a comment about the right implementation should the value be larger (and a request to add a test case when that happens). As it stands this code would just do bad things if you used the old CIE version and some target that didn't fit in an int?

http://reviews.llvm.org/D4027






More information about the llvm-commits mailing list