[PATCH] Fix line numbers for code inlined from __nodebug__ functions.

David Blaikie dblaikie at gmail.com
Thu Jun 5 08:42:12 PDT 2014


Thanks - looks great. One optional comment.

================
Comment at: test/DebugInfo/inline-no-debug-info.ll:23
@@ +22,3 @@
+; Debug location of the inlined code.
+; CHECK-DAG: [[B]] = metadata !{i32 2, i32 0, metadata !{{[01-9]+}}, metadata !{{[01-9]+}}}
+
----------------
It's probably worth having a similar check line for the value of A to demonstrate that they're both located at line 3, not line 2? (and if you like, you can omit everything after the field you care about (the first field, in this instance: "CHECK: [[X]] = metadata !{i32 42,") - but I don't feel strongly about it))

http://reviews.llvm.org/D3988






More information about the llvm-commits mailing list