[PATCH] [AArch64] Missing aliases for CMP/CMN [W]SP with no shift

[Artyom Skrobov]

Hello Tim et al,

After committing the patch mentioned below, we realized that the assembly strings which used to cause an assertion failure, then changed to a "too few operands" error, are in fact valid according to ARMARM C6.6.41 (CMN) and C6.6.44 (CMP); in fact, these assembly strings had already been generated when disassembling the corresponding encodings, and tested as part of arm64-arithmetic.txt

Our new patch adds the two aliases which were missing for CMP/CMN [W]SP with no shift, as well as updates the tests.

OK to commit?


-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: 29 May 2014 11:49
To: Artyom Skrobov
Cc: llvm-commits
Subject: Re: [PATCH] [AArch64] Fix MC assertion failures with certain invalid instructions

Hi Artyom,

On 29 May 2014 11:36, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:
> We have identified two MC issues in the newly-merged AArch64 backend.
> These lead to assertion failures when handling certain invalid instructions.

For the inverted condition code patch, I think it'd be very good to
comment what instruction that might be interpreted as. Also, if it's
undefined it should have a "# CHECK: invalid instruction encoding"
line associated (otherwise LLVM could start disassembling it, or any
other instruction in that file, and we'd not notice). If not, it
should be tested in a different file.

The too few operands patch looks fine.

Cheers.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CMP_CMN_SP_noshift.patch
Type: application/octet-stream
Size: 4142 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140605/1f7c2513/attachment.obj>