[llvm] r210182 - [AArch64] clang-format the load/store optimizer.

Tilmann Scheller t.scheller at samsung.com
Wed Jun 4 07:22:39 PDT 2014


Discussed this on IRC with James, he's ok with keeping the switch reformatted.

Motivation for the reformatting was that all other switch statements are already in the current clang-format style and the reformatted one was just the one-off.

Regards,

Tilmann

From: Daniel Jasper [mailto:djasper at google.com] 
Sent: Wednesday, June 04, 2014 3:47 PM
To: James Molloy
Cc: Tilmann Scheller; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r210182 - [AArch64] clang-format the load/store optimizer.

This is also something we want to fix: llvm.org/PR16535.. We just haven't had time to get on that yet.

On Wed, Jun 4, 2014 at 3:31 PM, James Molloy <james.molloy at arm.com> wrote:
Hi Tilmann,

We try not to run clang-format on full source files, because it messes up
the SVN blame history. In fact, the changes clang-format has made here don't
really make sense - the switch was more readable initially.

Could you please revert at least the switch part?

Cheers,

James







More information about the llvm-commits mailing list