[lld] r210174 - Add a comment, fix style.
Rui Ueyama
ruiu at google.com
Wed Jun 4 02:00:55 PDT 2014
Author: ruiu
Date: Wed Jun 4 04:00:55 2014
New Revision: 210174
URL: http://llvm.org/viewvc/llvm-project?rev=210174&view=rev
Log:
Add a comment, fix style.
Modified:
lld/trunk/lib/ReaderWriter/FileArchive.cpp
Modified: lld/trunk/lib/ReaderWriter/FileArchive.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/FileArchive.cpp?rev=210174&r1=210173&r2=210174&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/FileArchive.cpp (original)
+++ lld/trunk/lib/ReaderWriter/FileArchive.cpp Wed Jun 4 04:00:55 2014
@@ -120,6 +120,9 @@ protected:
return error_code();
}
+ // Parses the given memory buffer as an object file, and returns success error
+ // code if the given symbol is a data symbol. If the symbol is not a data
+ // symbol or does not exist, returns a failure.
error_code isDataSymbol(std::unique_ptr<MemoryBuffer> mb, StringRef symbol) const {
auto objOrErr(ObjectFile::createObjectFile(mb.release()));
if (auto ec = objOrErr.getError())
@@ -132,12 +135,9 @@ protected:
StringRef symbolname;
for (symbol_iterator i = ibegin; i != iend; ++i) {
- error_code ec;
-
// Get symbol name
- if ((ec = (i->getName(symbolname))))
+ if (error_code ec = i->getName(symbolname))
return ec;
-
if (symbolname != symbol)
continue;
@@ -148,12 +148,11 @@ protected:
continue;
// Get Symbol Type
- if ((ec = (i->getType(symtype))))
+ if (error_code ec = i->getType(symtype))
return ec;
- if (symtype == SymbolRef::ST_Data) {
+ if (symtype == SymbolRef::ST_Data)
return error_code();
- }
}
return object_error::parse_failed;
}
More information about the llvm-commits
mailing list