[llvm] r209927 - isSVR4ABI() returned !isDarwin() so just move that to the else

[Eric Christopher]

Fair, will get.

-eric

On Mon, Jun 2, 2014 at 10:08 AM, Robinson, Paul
<Paul_Robinson at playstation.sony.com> wrote:
>> -----Original Message-----
>> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>> bounces at cs.uiuc.edu] On Behalf Of Eric Christopher
>> Sent: Friday, May 30, 2014 3:48 PM
>> To: llvm-commits at cs.uiuc.edu
>> Subject: [llvm] r209927 - isSVR4ABI() returned !isDarwin() so just move
>> that to the else
>>
>> Author: echristo
>> Date: Fri May 30 17:47:53 2014
>> New Revision: 209927
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=209927&view=rev
>> Log:
>> isSVR4ABI() returned !isDarwin() so just move that to the else
>> block and remove the unreachable code.
>>
>> Modified:
>>     llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
>>
>> Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
>> URL: http://llvm.org/viewvc/llvm-
>> project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=209927&r1=
>> 209926&r2=209927&view=diff
>> ========================================================================
>> ======
>> --- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Fri May 30
>> 17:47:53 2014
>> @@ -53,11 +53,8 @@ extern cl::opt<bool> ANDIGlueBug;
>>  static TargetLoweringObjectFile *createTLOF(const PPCTargetMachine &TM)
>> {
>>    if (TM.getSubtargetImpl()->isDarwin())
>>      return new TargetLoweringObjectFileMachO();
>> -
>> -  if (TM.getSubtargetImpl()->isSVR4ABI())
>> +  else
>>      return new PPC64LinuxTargetObjectFile();
>
> Don't want 'else' after 'return'?
> --paulr
>
>> -
>> -  return new TargetLoweringObjectFileELF();
>>  }
>>
>>  PPCTargetLowering::PPCTargetLowering(PPCTargetMachine &TM)
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>