[PATCH] [InstCombine] Constant comparison involving "lshr exact"

[Rafael Ávila de Espíndola]

There is still quiet a bit of duplicated code. For example

 shift = Quotient.logBase2();
 return new ICmpInst(I.getPredicate(), A,
                         ConstantInt::get(A->getType(), shift));
                          ConstantInt::get(A->getType(), shift));


With a helper function it looks like you can return a boolean for "found optimization opportunity" and set the Quotient variable. That way the shif and the construction of the ICmpInst are shared.

http://reviews.llvm.org/D3987