[llvm] r209829 - Debug Info: Remove unused code. The MInsn of an _abstract_ variable is

[Adrian Prantl]

r209920.

> On May 29, 2014, at 10:26 AM, Adrian Prantl <aprantl at apple.com> wrote:
> 
> I agree! I’ll do that.
> 
> -- adrian
> 
> 
>> On May 29, 2014, at 10:24 AM, Eric Christopher <echristo at gmail.com> wrote:
>> 
>> Given that the remaining use of setMInsn can be inferred before
>> construction we could just fold the argument into the constructor now
>> I think.
>> 
>> -eric
>> 
>> On Thu, May 29, 2014 at 9:56 AM, Adrian Prantl <aprantl at apple.com> wrote:
>>> Author: adrian
>>> Date: Thu May 29 11:56:48 2014
>>> New Revision: 209829
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=209829&view=rev
>>> Log:
>>> Debug Info: Remove unused code. The MInsn of an _abstract_ variable is
>>> never used again and updating the abstract variable for each inlined
>>> instance of it was questionable in the first place.
>>> 
>>> Modified:
>>>   llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>>> 
>>> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=209829&r1=209828&r2=209829&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
>>> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Thu May 29 11:56:48 2014
>>> @@ -1179,8 +1179,6 @@ DwarfDebug::collectVariableInfo(SmallPtr
>>>    DbgVariable *RegVar = new DbgVariable(DV, AbsVar, this);
>>>    if (!addCurrentFnArgument(RegVar, Scope))
>>>      addScopeVariable(Scope, RegVar);
>>> -    if (AbsVar)
>>> -      AbsVar->setMInsn(MInsn);
>>> 
>>>    // Check if the first DBG_VALUE is valid for the rest of the function.
>>>    if (Ranges.size() == 1 && Ranges.front().second == nullptr) {
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits