[PATCH] Fix urem instruction with power of two to compute known bit.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri May 30 08:09:01 PDT 2014


Sorry, I missed this.

I committed the patch (r209902 ). I just updated the test to check for
assembly (as opposed to just generating it).

Normally in LLVM we test that the result is valid, not exactly the
steps that a transformation is doing. Doing that gives more freedom at
modifying the passes in the future.

We do try to write small tests and test the smallest part of llvm that
we can. It is really unfortunate with codegen that such a large piece
of code needs to be run, but I don't think that checking deubg output
is the correct way to fix that.

http://reviews.llvm.org/D3823






More information about the llvm-commits mailing list