[PATCH] Move duplicate Windows-specific compiler flags to a common CMake variable

[Timur Iskhodzhanov]

2014-05-29 21:03 GMT+04:00 Reid Kleckner <rnk at google.com>:

> drive by nits that were already there
>
> ================
> Comment at: cmake/Modules/AddCompilerRT.cmake:129
> @@ -126,1 +128,3 @@
>  if(MSVC)
> +  # MSVC system headers and gtest use a lot of deprecated stuff.
> +  list(APPEND COMPILER_RT_TEST_CFLAGS
> ----------------
> Can we use -isystem to suppress these?  Does -D_CRT_SECURE_NO_WARNINGS
> solve this problem?\
>

-D_CRT_SECURE_NO_WARNINGS doesn't solve the problem.


> ================
> Comment at: cmake/Modules/AddCompilerRT.cmake:137
> @@ +136,3 @@
> +
> +  # We should teach clang to understand more pragmas.
> +  list(APPEND COMPILER_RT_TEST_CFLAGS
> ----------------
> ditto, this can be handled with -isystem.
>

In fact, the warning comes from the sanitizer runtime code.

http://reviews.llvm.org/D3952