[PATCH] [LNT] Add geometric mean to run report

Yi Kong kongy.dev at gmail.com
Fri May 30 03:26:00 PDT 2014


On 30 May 2014 01:29, Chris Matthews <chris.matthews at apple.com> wrote:
> Duncan and I took a look at this, and have made some changes.
>
> A few things we changed:
>
> 1. Current was being compared with current, not prev, so it was not going to find much :)
> 2. We changed the offset from adding 1 then subtracting 1 to 0.00001, this should skew the new geomean less.
> 3. We introduced a safe min which maps min([]) to None.

I guess you need to introduce a "safe median" as well?

> 4. Changed the use of filter(None, because that can remove 0’s from the list
> 5. Cleanups so we could reason a little better about what is going on.
>
> Yi, what do you think of these changes?

Otherwise, LGTM.

Thanks a lot for your effort!




More information about the llvm-commits mailing list