[llvm] r209853 - Added tests for shufflevector lowering to blend instrs.

Quentin Colombet qcolombet at apple.com
Thu May 29 17:33:10 PDT 2014


Hi Filipe,

Could you check the actual arguments of the blend instruction in your test case?
I want to make sure we are doing the right lowering.

See r209324 for an example.

Thanks,
-Quentin

On May 29, 2014, at 3:04 PM, Filipe Cabecinhas <me at filcab.net> wrote:

> Author: filcab
> Date: Thu May 29 17:04:42 2014
> New Revision: 209853
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=209853&view=rev
> Log:
> Added tests for shufflevector lowering to blend instrs.
> 
> These tests ensure that a change I will propose in clang works as
> expected.
> 
> Summary:
> Added tests for the generation of blend+immediate instructions from a
> shufflevector.
> These tests were proposed along with a patch that was dropped. I'm
> committing the tests anyway to protect against possible regressions in
> codegen.
> 
> Reviewers: nadav, bkramer
> 
> Subscribers: llvm-commits
> 
> Differential Revision: http://reviews.llvm.org/D3600
> 
> Modified:
>    llvm/trunk/test/CodeGen/X86/avx-blend.ll
>    llvm/trunk/test/CodeGen/X86/avx2-shuffle.ll
>    llvm/trunk/test/CodeGen/X86/sse41-blend.ll
> 
> Modified: llvm/trunk/test/CodeGen/X86/avx-blend.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx-blend.ll?rev=209853&r1=209852&r2=209853&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/avx-blend.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/avx-blend.ll Thu May 29 17:04:42 2014
> @@ -158,3 +158,36 @@ define <8 x float> @constant_blendvps_av
> 
> declare <8 x float> @llvm.x86.avx.blendv.ps.256(<8 x float>, <8 x float>, <8 x float>)
> declare <4 x double> @llvm.x86.avx.blendv.pd.256(<4 x double>, <4 x double>, <4 x double>)
> +
> +;; 4 tests for shufflevectors that optimize to blend + immediate
> +; CHECK-LABEL: @blend_shufflevector_4xfloat
> +define <4 x float> @blend_shufflevector_4xfloat(<4 x float> %a, <4 x float> %b) {
> +; CHECK: vblendps
> +; CHECK: ret
> +  %1 = shufflevector <4 x float> %a, <4 x float> %b, <4 x i32> <i32 0, i32 5, i32 2, i32 7>
> +  ret <4 x float> %1
> +}
> +
> +; CHECK-LABEL: @blend_shufflevector_8xfloat
> +define <8 x float> @blend_shufflevector_8xfloat(<8 x float> %a, <8 x float> %b) {
> +; CHECK: vblendps
> +; CHECK: ret
> +  %1 = shufflevector <8 x float> %a, <8 x float> %b, <8 x i32> <i32 0, i32 9, i32 10, i32 11, i32 12, i32 13, i32 6, i32 15>
> +  ret <8 x float> %1
> +}
> +
> +; CHECK-LABEL: @blend_shufflevector_4xdouble
> +define <4 x double> @blend_shufflevector_4xdouble(<4 x double> %a, <4 x double> %b) {
> +; CHECK: vblendpd
> +; CHECK: ret
> +  %1 = shufflevector <4 x double> %a, <4 x double> %b, <4 x i32> <i32 0, i32 5, i32 2, i32 3>
> +  ret <4 x double> %1
> +}
> +
> +; CHECK-LABEL: @blend_shufflevector_4xi64
> +define <4 x i64> @blend_shufflevector_4xi64(<4 x i64> %a, <4 x i64> %b) {
> +; CHECK: vblendpd
> +; CHECK: ret
> +  %1 = shufflevector <4 x i64> %a, <4 x i64> %b, <4 x i32> <i32 4, i32 1, i32 6, i32 7>
> +  ret <4 x i64> %1
> +}
> 
> Modified: llvm/trunk/test/CodeGen/X86/avx2-shuffle.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx2-shuffle.ll?rev=209853&r1=209852&r2=209853&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/avx2-shuffle.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/avx2-shuffle.ll Thu May 29 17:04:42 2014
> @@ -60,6 +60,24 @@ define <4 x i64> @blend_test4(<4 x i64>
>   ret <4 x i64> %t
> }
> 
> +;; 2 tests for shufflevectors that optimize to blend + immediate
> +; CHECK-LABEL: @blend_test5
> +; CHECK: vpblendd
> +; CHECK: ret
> +define <4 x i32> @blend_test5(<4 x i32> %a, <4 x i32> %b) {
> +  %1 = shufflevector <4 x i32> %a, <4 x i32> %b, <4 x i32> <i32 0, i32 5, i32 2, i32 7>
> +  ret <4 x i32> %1
> +}
> +
> +; CHECK-LABEL: @blend_test6
> +; CHECK: vpblendw
> +; CHECK: ret
> +define <16 x i16> @blend_test6(<16 x i16> %a, <16 x i16> %b) {
> +  %1 = shufflevector <16 x i16> %a, <16 x i16> %b, <16 x i32> <i32 0, i32 17, i32 18, i32  3, i32  4, i32  5, i32  6, i32 23,
> +                                                               i32 8, i32 25, i32 26, i32 11, i32 12, i32 13, i32 14, i32 31>
> +  ret <16 x i16> %1
> +}
> +
> ; CHECK: vpshufhw $27, %ymm
> define <16 x i16> @vpshufhw(<16 x i16> %src1) nounwind uwtable readnone ssp {
> entry:
> 
> Modified: llvm/trunk/test/CodeGen/X86/sse41-blend.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/sse41-blend.ll?rev=209853&r1=209852&r2=209853&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/sse41-blend.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/sse41-blend.ll Thu May 29 17:04:42 2014
> @@ -117,6 +117,24 @@ define <16 x i8> @constant_pblendvb(<16
>   %1 = select <16 x i1> <i1 false, i1 false, i1 true, i1 false, i1 true, i1 true, i1 true, i1 false, i1 false, i1 false, i1 true, i1 false, i1 true, i1 true, i1 true, i1 false>, <16 x i8> %xyzw, <16 x i8> %abcd
>   ret <16 x i8> %1
> }
> +
> declare <16 x i8> @llvm.x86.sse41.pblendvb(<16 x i8>, <16 x i8>, <16 x i8>)
> declare <4 x float> @llvm.x86.sse41.blendvps(<4 x float>, <4 x float>, <4 x float>)
> declare <2 x double> @llvm.x86.sse41.blendvpd(<2 x double>, <2 x double>, <2 x double>)
> +
> +;; 2 tests for shufflevectors that optimize to blend + immediate
> +; CHECK-LABEL: @blend_shufflevector_4xfloat
> +; CHECK: blendps
> +; CHECK: ret
> +define <4 x float> @blend_shufflevector_4xfloat(<4 x float> %a, <4 x float> %b) {
> +  %1 = shufflevector <4 x float> %a, <4 x float> %b, <4 x i32> <i32 0, i32 5, i32 6, i32 3>
> +  ret <4 x float> %1
> +}
> +
> +; CHECK-LABEL: @blend_shufflevector_8xi16
> +; CHECK: pblendw
> +; CHECK: ret
> +define <8 x i16> @blend_shufflevector_8xi16(<8 x i16> %a, <8 x i16> %b) {
> +  %1 = shufflevector <8 x i16> %a, <8 x i16> %b, <8 x i32> <i32 0, i32 9, i32 10, i32 3, i32 4, i32 5, i32 6, i32 15>
> +  ret <8 x i16> %1
> +}
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list