[PATCH] Move duplicate Windows-specific compiler flags to a common CMake variable
Reid Kleckner
rnk at google.com
Thu May 29 10:03:48 PDT 2014
drive by nits that were already there
================
Comment at: cmake/Modules/AddCompilerRT.cmake:129
@@ -126,1 +128,3 @@
if(MSVC)
+ # MSVC system headers and gtest use a lot of deprecated stuff.
+ list(APPEND COMPILER_RT_TEST_CFLAGS
----------------
Can we use -isystem to suppress these? Does -D_CRT_SECURE_NO_WARNINGS solve this problem?
================
Comment at: cmake/Modules/AddCompilerRT.cmake:137
@@ +136,3 @@
+
+ # We should teach clang to understand more pragmas.
+ list(APPEND COMPILER_RT_TEST_CFLAGS
----------------
ditto, this can be handled with -isystem.
http://reviews.llvm.org/D3952
More information about the llvm-commits
mailing list