[PATCH] [PECOFF] Support COMDAT associative sections.

Simon Atanasyan simon at atanasyan.com
Thu May 29 05:03:32 PDT 2014


LGTM with minor question / note.

================
Comment at: lib/ReaderWriter/PECOFF/ReaderCOFF.cpp:174
@@ +173,3 @@
+  // COMDAT associative sections
+  std::map<const coff_section *, std::set<const coff_section *>> _association;
+
----------------
Is it really necessary to use the `std::set` here i.e. is it possible that a COFF file contains more than one "record" states that sections say "A" and "B" are associated?

http://reviews.llvm.org/D3946






More information about the llvm-commits mailing list