[PATCH] [ASan/Win] Use clang rather than clang-cl by default for lit tests. Make Windows-only tests explicitly use clang-cl.

Timur Iskhodzhanov timurrrr at google.com
Wed May 28 01:49:42 PDT 2014


Landed as r209719, thanks for the review!

================
Comment at: lib/sanitizer_common/tests/CMakeLists.txt:60
@@ -58,3 +59,3 @@
   list(APPEND SANITIZER_TEST_CFLAGS_COMMON
-       /fallback
+       -DGTEST_HAS_SEH=0
        -D_HAS_EXCEPTIONS=0)
----------------
Alexey Samsonov wrote:
> GTEST_HAS_SEH=0 now comes from OMPILER_RT_GTEST_CFLAGS, doesn't it?
Oops, missed that -- thanks for catching!

I should probably move the stuff we conditionally append to SANITIZER_TEST_CFLAGS_COMMON to COMPILER_RT_GTEST_CFLAGS instead.  Will do that in a separate commit.

http://reviews.llvm.org/D3893






More information about the llvm-commits mailing list