[PATCH] Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads

Nadav Rotem nrotem at apple.com
Tue May 27 22:25:53 PDT 2014


Karthik, 

Please document the code that you are adding to the vectorization of binary operators.  

+          buildTree_rec(Left, Depth + 1);
+       }
+       else {

Please format your patch properly. 

Also, would it be better to swap Right and Left instead of duplicating the calls to buildTree_rec?

The performance numbers look okay. Do you know why we see a nice gain in the one workloads that wins?

Thanks,
Nadav

http://reviews.llvm.org/D3800






More information about the llvm-commits mailing list