[llvm] r209646 - AArch64: support 'c' and 'n' inline asm modifiers.

David Blaikie dblaikie at gmail.com
Tue May 27 09:20:17 PDT 2014


On Tue, May 27, 2014 at 12:37 AM, Tim Northover <tnorthover at apple.com> wrote:
> Author: tnorthover
> Date: Tue May 27 02:37:21 2014
> New Revision: 209646
>
> URL: http://llvm.org/viewvc/llvm-project?rev=209646&view=rev
> Log:
> AArch64: support 'c' and 'n' inline asm modifiers.
>
> These are tested by test/CodeGen/Generic, so we should probably know
> how to deal with them. Fortunately generic code does it if asked.

Is there a test case for this change, though?

>
> Modified:
>     llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp
>
> Modified: llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp?rev=209646&r1=209645&r2=209646&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp Tue May 27 02:37:21 2014
> @@ -266,6 +266,11 @@ bool AArch64AsmPrinter::PrintAsmOperand(
>                                          unsigned AsmVariant,
>                                          const char *ExtraCode, raw_ostream &O) {
>    const MachineOperand &MO = MI->getOperand(OpNum);
> +
> +  // First try the generic code, which knows about modifiers like 'c' and 'n'.
> +  if (!AsmPrinter::PrintAsmOperand(MI, OpNum, AsmVariant, ExtraCode, O))
> +    return false;
> +
>    // Does this asm operand have a single letter operand modifier?
>    if (ExtraCode && ExtraCode[0]) {
>      if (ExtraCode[1] != 0)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list