[PATCH] [ARM] Emit correct build attributes for the different relocation models

[Tim Northover]

Hi Asiri,

The code looks correct to me, from what I understand of the ABI. I've just got one issue with the comments

Cheers.

Tim.

================
Comment at: include/llvm/Support/ARMBuildAttributes.h:150-151
@@ +149,4 @@
+  // Tag_ABI_PCS_RW_data, (=15), uleb128
+  AddressRWPCRel = 1, // Permit PC-relative addressing of RW static data
+  AddressRWSBRel = 2, // Permit SB-relative addressing of RW static data
+  AddressRWNone = 3, // No RW static data permitted
----------------
I think the comments are misleading: the point is that compatible objects *must* use PCRel or SBRel addressing, not that they can if they want to.

I was confused until I looked at the actual ABI addendum.

http://reviews.llvm.org/D3918