[llvm] r209599 - Make these CHECKs a bit more strict.

Sun May 25 21:16:55 PDT 2014

sure, r209610.

On 25 May 2014 10:20, David Blaikie <dblaikie at gmail.com> wrote:
> Is it worth/possible to put the wrote at the start to, for symmetry (or is
> there something else before it in the same string?) - otherwise I would
> wonder if the difference between the start and end was significant in some
> way.
>
> On May 25, 2014 5:53 AM, "Rafael Espindola" <rafael.espindola at gmail.com>
> wrote:
>>
>> Author: rafael
>> Date: Sun May 25 07:43:13 2014
>> New Revision: 209599
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=209599&view=rev
>> Log:
>> Make these CHECKs a bit more strict.
>>
>> The " at the end of the line makes sure we matched the entire directive.
>>
>> Modified:
>>     llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll
>>     llvm/trunk/test/CodeGen/X86/dllexport.ll
>>
>> Modified: llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll?rev=209599&r1=209598&r2=209599&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll (original)
>> +++ llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll Sun May 25 07:43:13
>> 2014
>> @@ -74,31 +74,31 @@ define weak_odr dllexport void @weak1()
>>
>>
>>  ; CHECK: .section .drectve
>> -; WIN32: /EXPORT:Var1,DATA
>> -; WIN32: /EXPORT:Var2,DATA
>> -; WIN32: /EXPORT:Var3,DATA
>> -; WIN32: /EXPORT:WeakVar1,DATA
>> -; WIN32: /EXPORT:WeakVar2,DATA
>> -; WIN32: /EXPORT:f1
>> -; WIN32: /EXPORT:f2
>> -; WIN32: /EXPORT:lnk1
>> -; WIN32: /EXPORT:lnk2
>> -; WIN32: /EXPORT:weak1
>> -; WIN32: /EXPORT:alias
>> -; WIN32: /EXPORT:alias2
>> -; WIN32: /EXPORT:alias3
>> -; WIN32: /EXPORT:weak_alias
>> -; MINGW: -export:Var1,data
>> -; MINGW: -export:Var2,data
>> -; MINGW: -export:Var3,data
>> -; MINGW: -export:WeakVar1,data
>> -; MINGW: -export:WeakVar2,data
>> -; MINGW: -export:f1
>> -; MINGW: -export:f2
>> -; MINGW: -export:lnk1
>> -; MINGW: -export:lnk2
>> -; MINGW: -export:weak1
>> -; MINGW: -export:alias
>> -; MINGW: -export:alias2
>> -; MINGW: -export:alias3
>> -; MINGW: -export:weak_alias
>> +; WIN32: /EXPORT:Var1,DATA"
>> +; WIN32: /EXPORT:Var2,DATA"
>> +; WIN32: /EXPORT:Var3,DATA"
>> +; WIN32: /EXPORT:WeakVar1,DATA"
>> +; WIN32: /EXPORT:WeakVar2,DATA"
>> +; WIN32: /EXPORT:f1"
>> +; WIN32: /EXPORT:f2"
>> +; WIN32: /EXPORT:lnk1"
>> +; WIN32: /EXPORT:lnk2"
>> +; WIN32: /EXPORT:weak1"
>> +; WIN32: /EXPORT:alias"
>> +; WIN32: /EXPORT:alias2"
>> +; WIN32: /EXPORT:alias3"
>> +; WIN32: /EXPORT:weak_alias"
>> +; MINGW: -export:Var1,data"
>> +; MINGW: -export:Var2,data"
>> +; MINGW: -export:Var3,data"
>> +; MINGW: -export:WeakVar1,data"
>> +; MINGW: -export:WeakVar2,data"
>> +; MINGW: -export:f1"
>> +; MINGW: -export:f2"
>> +; MINGW: -export:lnk1"
>> +; MINGW: -export:lnk2"
>> +; MINGW: -export:weak1"
>> +; MINGW: -export:alias"
>> +; MINGW: -export:alias2"
>> +; MINGW: -export:alias3"
>> +; MINGW: -export:weak_alias"
>>
>> Modified: llvm/trunk/test/CodeGen/X86/dllexport.ll
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport.ll?rev=209599&r1=209598&r2=209599&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/test/CodeGen/X86/dllexport.ll (original)
>> +++ llvm/trunk/test/CodeGen/X86/dllexport.ll Sun May 25 07:43:13 2014
>> @@ -93,38 +93,38 @@ define weak_odr dllexport void @weak1()
>>
>>
>>  ; CHECK: .section .drectve
>> -; CHECK-CL: /EXPORT:_Var1,DATA
>> -; CHECK-CL: /EXPORT:_Var2,DATA
>> -; CHECK-CL: /EXPORT:_Var3,DATA
>> -; CHECK-CL: /EXPORT:_WeakVar1,DATA
>> -; CHECK-CL: /EXPORT:_WeakVar2,DATA
>> -; CHECK-CL: /EXPORT:_f1
>> -; CHECK-CL: /EXPORT:_f2
>> -; CHECK-CL: /EXPORT:_stdfun at 0
>> -; CHECK-CL: /EXPORT:@fastfun at 0
>> -; CHECK-CL: /EXPORT:_thisfun
>> -; CHECK-CL: /EXPORT:_lnk1
>> -; CHECK-CL: /EXPORT:_lnk2
>> -; CHECK-CL: /EXPORT:_weak1
>> -; CHECK-CL: /EXPORT:_alias
>> -; CHECK-CL: /EXPORT:_alias2
>> -; CHECK-CL: /EXPORT:_alias3
>> -; CHECK-CL: /EXPORT:_weak_alias
>> -; CHECK-GCC: -export:Var1,data
>> -; CHECK-GCC: -export:Var2,data
>> -; CHECK-GCC: -export:Var3,data
>> -; CHECK-GCC: -export:WeakVar1,data
>> -; CHECK-GCC: -export:WeakVar2,data
>> -; CHECK-GCC: -export:f1
>> -; CHECK-GCC: -export:f2
>> -; CHECK-GCC: -export:stdfun at 0
>> -; CHECK-GCC: -export:@fastfun at 0
>> -; CHECK-GCC: -export:thisfun
>> -; CHECK-GCC: -export:lnk1
>> -; CHECK-GCC: -export:lnk2
>> -; CHECK-GCC: -export:weak1
>> -; CHECK-GCC: -export:alias
>> -; CHECK-GCC: -export:alias2
>> -; CHECK-GCC: -export:alias3
>> -; CHECK-GCC: -export:weak_alias
>> +; CHECK-CL: /EXPORT:_Var1,DATA"
>> +; CHECK-CL: /EXPORT:_Var2,DATA"
>> +; CHECK-CL: /EXPORT:_Var3,DATA"
>> +; CHECK-CL: /EXPORT:_WeakVar1,DATA"
>> +; CHECK-CL: /EXPORT:_WeakVar2,DATA"
>> +; CHECK-CL: /EXPORT:_f1"
>> +; CHECK-CL: /EXPORT:_f2"
>> +; CHECK-CL: /EXPORT:_stdfun at 0"
>> +; CHECK-CL: /EXPORT:@fastfun at 0"
>> +; CHECK-CL: /EXPORT:_thisfun"
>> +; CHECK-CL: /EXPORT:_lnk1"
>> +; CHECK-CL: /EXPORT:_lnk2"
>> +; CHECK-CL: /EXPORT:_weak1"
>> +; CHECK-CL: /EXPORT:_alias"
>> +; CHECK-CL: /EXPORT:_alias2"
>> +; CHECK-CL: /EXPORT:_alias3"
>> +; CHECK-CL: /EXPORT:_weak_alias"
>> +; CHECK-GCC: -export:Var1,data"
>> +; CHECK-GCC: -export:Var2,data"
>> +; CHECK-GCC: -export:Var3,data"
>> +; CHECK-GCC: -export:WeakVar1,data"
>> +; CHECK-GCC: -export:WeakVar2,data"
>> +; CHECK-GCC: -export:f1"
>> +; CHECK-GCC: -export:f2"
>> +; CHECK-GCC: -export:stdfun at 0"
>> +; CHECK-GCC: -export:@fastfun at 0"
>> +; CHECK-GCC: -export:thisfun"
>> +; CHECK-GCC: -export:lnk1"
>> +; CHECK-GCC: -export:lnk2"
>> +; CHECK-GCC: -export:weak1"
>> +; CHECK-GCC: -export:alias"
>> +; CHECK-GCC: -export:alias2"
>> +; CHECK-GCC: -export:alias3"
>> +; CHECK-GCC: -export:weak_alias"
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits