[patch] Emit data or code export directives based on the type

Nico Rieck nico.rieck at gmail.com
Sun May 25 03:30:42 PDT 2014


On 25.05.2014 01:46, Rafael EspĂ­ndola wrote:
> Currently we look at the Aliasee to decide what type of export
> directive to use. It seems better to use the type of the alias
> directly. This is similar to how we handle with the alias having the
> same address but other attributes (linkage, visibility) from the
> aliasee.

 ; WIN32: /EXPORT:weak_alias
+; WIN32: /EXPORT:blob_alias"

It might not be immediately obvious why there's a quotation mark at the
end. This fuzzy matching has bitten me before. Should the other non-data
checks also get one? Otherwise LGTM.

-Nico



More information about the llvm-commits mailing list