[PATCH] [ASan/Win] Use clang rather than clang-cl by default for lit tests. Make Windows-only tests explicitly use clang-cl.

[Timur Iskhodzhanov]

Re: -g
1) clang crashes on windows with -g [fixable]
2) we had a chat with Kostya and decided it's the right thing to test ASan
with just glto to be sure it gives us enough DI
24 мая 2014 г. 2:07 пользователь "Alexey Samsonov" <vonosmas at gmail.com>
написал:

> ================
> Comment at: cmake/Modules/AddCompilerRT.cmake:151
> @@ -151,3 +150,3 @@
>      COMMAND ${COMPILER_RT_TEST_COMPILER} ${TEST_OBJECTS}
> -            ${COMPILER_RT_TEST_COMPILER_EXE}"${output_bin}"
> +            -o"${output_bin}"
>              ${TEST_LINK_FLAGS}
> ----------------
> Restore a space here.
>
> ================
> Comment at: cmake/Modules/CompilerRTCompile.cmake:24
> @@ +23,3 @@
> +  if(MSVC)
> +    string(REPLACE ";/" ";-" global_flags "${global_flags}")
> +  endif()
> ----------------
> what if the first element of global_flags starts with / ?
>
> ================
> Comment at: cmake/Modules/CompilerRTCompile.cmake:33
> @@ -27,3 +32,3 @@
>      COMMAND ${COMPILER_RT_TEST_COMPILER} ${compile_flags} -c
> -            ${COMPILER_RT_TEST_COMPILER_OBJ}"${object_file}"
> +            -o"${object_file}"
>              ${source_rpath}
> ----------------
> and here.
>
> ================
> Comment at: lib/asan/tests/CMakeLists.txt:29
> @@ -28,1 +28,3 @@
>    -I${COMPILER_RT_SOURCE_DIR}/lib/sanitizer_common/tests
> +  -DGTEST_HAS_RTTI=0
> +  -fno-rtti
> ----------------
> Consider adding this (and, probably, -DGTEST_HAS_SEH=0 on Windows) to
> COMPILER_RT_GTEST_CFLAGS definition instead.
>
> ================
> Comment at: lib/asan/tests/CMakeLists.txt:31
> @@ +30,3 @@
> +  -fno-rtti
> +  -gline-tables-only
> +  -O2
> ----------------
> Any particular reason to switch to -gline-tables-only from -g here?
>
> http://reviews.llvm.org/D3893
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140524/a2076b04/attachment.html>