[PATCH] Fix PR19657 : SLP vectorization doesn't combine scalar load to vector loads

[Raul Silvera]

I agree this is an improvement, but this approach is still failing to catch
cases where the common uses are not on separate paths on the tree. In those
cases no matter which order we take there will be a common use that can't
be scheduled.

Here is a sample case where we still fail to schedule a common load:

void foo(double *x, double C) {
>  x[0] = x[0]*C + x[0] * x[0];
>  x[1] = x[1]*C + x[1] * x[1];
> }

Any ideas on how to get those cases? It would seem to me we'd need either a
prepass or deferral of the decisions until the whole tree is inspected.
Thoughts?

Raúl E Silvera | SWE | rsilvera at google.com | *408-789-2846*



On Fri, May 23, 2014 at 9:32 AM, Nadav Rotem <nrotem at apple.com> wrote:

> Hi Karthik,
>
> Can you please measure the effects of this patch on the LLVM test suite?
>  It would be interesting to see if other workloads are affected by this
> change and if they improve or regress.
>
> Thanks,
> Nadav
>
> http://reviews.llvm.org/D3800
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140523/049f783e/attachment.html>