[llvm] r209529 - Add FIXME comment based on code review feedback by Hal Finkel on r209338

David Blaikie dblaikie at gmail.com
Fri May 23 09:53:15 PDT 2014


Author: dblaikie
Date: Fri May 23 11:53:14 2014
New Revision: 209529

URL: http://llvm.org/viewvc/llvm-project?rev=209529&view=rev
Log:
Add FIXME comment based on code review feedback by Hal Finkel on r209338

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=209529&r1=209528&r2=209529&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Fri May 23 11:53:14 2014
@@ -2371,6 +2371,8 @@ void DwarfDebug::addDwarfTypeUnitType(Dw
   if (!useSplitDwarf())
     CU.applyStmtList(UnitDie);
 
+  // FIXME: Skip using COMDAT groups for type units in the .dwo file once tools
+  // such as DWP ( http://gcc.gnu.org/wiki/DebugFissionDWP ) can cope with it.
   NewTU.initSection(
       useSplitDwarf()
           ? Asm->getObjFileLowering().getDwarfTypesDWOSection(Signature)





More information about the llvm-commits mailing list