[llvm] r209499 - Rename a couple of variables to be more accurate.

David Blaikie dblaikie at gmail.com
Thu May 22 22:03:23 PDT 2014


Author: dblaikie
Date: Fri May 23 00:03:23 2014
New Revision: 209499

URL: http://llvm.org/viewvc/llvm-project?rev=209499&view=rev
Log:
Rename a couple of variables to be more accurate.

It's not really a "ScopeDIE", as such - it's the abstract function
definition's DIE. And we usually use "SP" for subprograms, rather than
"Sub".

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=209499&r1=209498&r2=209499&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Fri May 23 00:03:23 2014
@@ -521,19 +521,19 @@ void DwarfDebug::constructAbstractSubpro
   assert(Scope->isAbstractScope());
   assert(!Scope->getInlinedAt());
 
-  DISubprogram Sub(Scope->getScopeNode());
+  DISubprogram SP(Scope->getScopeNode());
 
-  if (!ProcessedSPNodes.insert(Sub))
+  if (!ProcessedSPNodes.insert(SP))
     return;
 
   // Find the subprogram's DwarfCompileUnit in the SPMap in case the subprogram
   // was inlined from another compile unit.
-  DwarfCompileUnit &SPCU = *SPMap[Sub];
-  DIE *ScopeDIE = SPCU.getDIE(Sub);
-  assert(ScopeDIE);
-  AbstractSPDies.insert(std::make_pair(Sub, ScopeDIE));
-  SPCU.addUInt(*ScopeDIE, dwarf::DW_AT_inline, None, dwarf::DW_INL_inlined);
-  createAndAddScopeChildren(SPCU, Scope, *ScopeDIE);
+  DwarfCompileUnit &SPCU = *SPMap[SP];
+  DIE *AbsDef = SPCU.getDIE(SP);
+  assert(AbsDef);
+  AbstractSPDies.insert(std::make_pair(SP, AbsDef));
+  SPCU.addUInt(*AbsDef, dwarf::DW_AT_inline, None, dwarf::DW_INL_inlined);
+  createAndAddScopeChildren(SPCU, Scope, *AbsDef);
 }
 
 DIE &DwarfDebug::constructSubprogramScopeDIE(DwarfCompileUnit &TheCU,





More information about the llvm-commits mailing list