[PATCH] error_code for dynamically generated error messages

[Shankar Easwaran]

================
Comment at: lib/Core/Error.cpp:180
@@ +179,3 @@
+    llvm::sys::SmartScopedLock<true> lock(_mutex);
+    // Value zero is always the successs value.
+    if (_messages.empty())
----------------
Nit pick spell error of success 

================
Comment at: lib/Core/Error.cpp:189
@@ +188,3 @@
+private:
+  std::vector<std::string> _messages;
+  llvm::sys::SmartMutex<true> _mutex;
----------------
How do we use the vector of messages ? Are these for predefined messages ? If so should it be a vector of StringRef ?

http://reviews.llvm.org/D3881