[PATCH] Add support for missed and analysis optimization remarks.

[Diego Novillo]

On Wed, May 14, 2014 at 4:51 PM, Quentin Colombet <qcolombet at apple.com>wrote:

> Hi Diego,
>
> This overall LGTM.
> I have one concern though.
> The LLVMContext begins to have a lot of its API dedicated to diagnostic
> report. All those helper functions calls LLVMContext::diagnose and I would
> prefer to have just this specific method (emitError being the exception)
> than having a profusion of such helpers in that class.
> I think it would make sense to have those helper functions in the
> DiagnosticInfo header. That way it would be better self contained.
> This is my 2 cents.
>
> What do you think?
>

Sounds reasonable. I just updated the patch with your suggestion. Is that
what you had in mind?


Thanks. Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140521/a7068851/attachment.html>