[patch][pr10367] Add support for offsets in GlobalAlias

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue May 20 15:28:27 PDT 2014


> I think you should explicitly state that the offset is in bytes.

Good idea. Fixed.

>> +  const APSInt &Val = Lex.getAPSIntVal();
>> +  if (Val.getBitWidth() > 64)
>> +    return TokError("expected a 64 bit unsegned integer");
>
> s/unsegned/unsigned

Oh, on the current patch the offset is signed. I just forgot to update
the error message. I fixed it in the attached version.

Thanks,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 17402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140520/a85426a6/attachment.obj>


More information about the llvm-commits mailing list