[PATCH] [asan-assembly-instrumentation] Fixed operations with stack in assembly instrumentation.

Yuri Gorshenin ygorshenin at chromium.org
Tue May 20 09:18:28 PDT 2014


PTAL

================
Comment at: lib/asan/tests/CMakeLists.txt:63
@@ -62,2 +62,3 @@
   "-fsanitize-blacklist=${ASAN_BLACKLIST_FILE}"
+  -mllvm -asan-instrument-assembly
 )
----------------
Evgeniy Stepanov wrote:
> Please add a simple test case that's affected by this flag!
> Something like AddressSanitizer.BitFieldPositiveTest but with asm store or load instead of C assingment.
Done.

================
Comment at: lib/asan/tests/asan_asm_test.cc:228
@@ +227,3 @@
+          : "rax", "memory");
+  ASSERT_EQ(0x1, r);
+#else
----------------
Evgeniy Stepanov wrote:
> remove please
Done.

================
Comment at: lib/asan/tests/asan_asm_test.cc:249
@@ -214,1 +248,3 @@
+
+  TestFlags();
 }
----------------
Evgeniy Stepanov wrote:
> Could you make it a separate test case?
Done.

http://reviews.llvm.org/D3839






More information about the llvm-commits mailing list