[PATCH] [asm matcher] Fix incorrect assertion when there are exactly 32 SubtargetFeatures

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue May 20 09:16:01 PDT 2014


LGTM with a nit.

================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2209
@@ +2208,3 @@
+static const char *getMinimalTypeForRange(uint64_t Range) {
+  assert(Range < 0xFFFFFFFFULL && "Enum too large");
+  if (Range > 0xFFFF)
----------------
If this is the maximum used value, the assert should be <=, no?

http://reviews.llvm.org/D3787






More information about the llvm-commits mailing list