[PATCH] [asan] disable fast unwind on ARM

Greg Fitzgerald gregf at codeaurora.org
Mon May 19 16:13:46 PDT 2014


Per Kostya, this version does not disable fast unwind on Android.

With this patch, the error messages are significantly more useful.  Without this patch, in the use-after-free test for example, the stack trace only has references to the 'malloc/free' wrappers in the ASan runtime and not references to anything in use-after-free.cc.

http://reviews.llvm.org/D3814

Files:
  lib/sanitizer_common/sanitizer_stacktrace.h

Index: lib/sanitizer_common/sanitizer_stacktrace.h
===================================================================
--- lib/sanitizer_common/sanitizer_stacktrace.h
+++ lib/sanitizer_common/sanitizer_stacktrace.h
@@ -21,7 +21,8 @@
 
 #if SANITIZER_LINUX && (defined(__aarch64__) || defined(__powerpc__) || \
                         defined(__powerpc64__) || defined(__sparc__) || \
-                        defined(__mips__))
+                        defined(__mips__) || \
+                        (!SANITIZER_ANDROID && defined(__arm__)))
 # define SANITIZER_CAN_FAST_UNWIND 0
 #elif SANITIZER_WINDOWS
 # define SANITIZER_CAN_FAST_UNWIND 0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3814.9591.patch
Type: text/x-patch
Size: 645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140519/3adc4770/attachment.bin>


More information about the llvm-commits mailing list