[PATCH] Added inst combine transforms for single bit tests from Chris's note (updated)

Dinesh Dwivedi dinesh.d at samsung.com
Sun May 18 12:52:03 PDT 2014


Thanks, I am finally able to recognize problem with the patch. I have missed to check if true/ false values are same as one of the operand in comp instruction.

Added 5 more test where my changes should not do anything. Y |= C case is combined by code following my changes in foldSelectICmpAndOr. These are kind of negative cases and if we add some transform for tested conditions, these test will fail. Do we keep this type of tests?

http://reviews.llvm.org/D3777

Files:
  lib/Transforms/InstCombine/InstCombineSelect.cpp
  test/Transforms/InstCombine/select.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3777.9517.patch
Type: text/x-patch
Size: 5496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140518/aeb98997/attachment.bin>


More information about the llvm-commits mailing list