[llvm] r209007 - Fix most of PR10367.

[John McCall]

On May 16, 2014, at 12:35 PM, Rafael Espindola <rafael.espindola at gmail.com> wrote:
> Author: rafael
> Date: Fri May 16 14:35:39 2014
> New Revision: 209007
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=209007&view=rev
> Log:
> Fix most of PR10367.
> 
> This patch changes the design of GlobalAlias so that it doesn't take a
> ConstantExpr anymore. It now points directly to a GlobalObject, but its type is
> independent of the aliasee type.

I’m sorry that I didn’t see your patch before you committed.  Can you explain
what benefits this has over allowing a (restricted) ConstantExpr in the
aliasee?

My understanding is that Chris has changed his mind since he originally
filed PR10367.  It certainly seems to me that, if we’re going to support
non-zero offsets and addrspace conversions and so on in aliases, it’s
far better to allow a restricted restricted set of constant expressions than
it is to awkwardly replicate all of that functionality specifically for
GlobalAlias.

John.