[llvm] r208998 - [ARM64] Fix wrong comment in load/store optimization pass.

Tilmann Scheller t.scheller at samsung.com
Fri May 16 09:50:13 PDT 2014


Author: tilmann
Date: Fri May 16 11:50:13 2014
New Revision: 208998

URL: http://llvm.org/viewvc/llvm-project?rev=208998&view=rev
Log:
[ARM64] Fix wrong comment in load/store optimization pass.

ldr x1, [x0, #64]
add x0, x0, #64
 ->
ldr x1, [x0], #64

is not a valid transformation, the correct transformation (and what the code actually does) is:

ldr x1, [x0, #64]
add x0, x0, #64
 ->
ldr x1, [x0, #64]!

Modified:
    llvm/trunk/lib/Target/ARM64/ARM64LoadStoreOptimizer.cpp

Modified: llvm/trunk/lib/Target/ARM64/ARM64LoadStoreOptimizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/ARM64LoadStoreOptimizer.cpp?rev=208998&r1=208997&r2=208998&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM64/ARM64LoadStoreOptimizer.cpp (original)
+++ llvm/trunk/lib/Target/ARM64/ARM64LoadStoreOptimizer.cpp Fri May 16 11:50:13 2014
@@ -892,7 +892,7 @@ bool ARM64LoadStoreOpt::optimizeBlock(Ma
       // ldr x1, [x0, #64]
       // add x0, x0, #64
       //   merged into:
-      // ldr x1, [x0], #64
+      // ldr x1, [x0, #64]!
 
       // The immediate in the load/store is scaled by the size of the register
       // being loaded. The immediate in the add we're looking for,





More information about the llvm-commits mailing list