[PATCH] Generalize stackdepot.

Alexander Potapenko glider at google.com
Fri May 16 05:26:02 PDT 2014


================
Comment at: sanitizer_common/sanitizer_chainedorigindepot.cc:10
@@ +9,3 @@
+//
+// This file is shared between AddressSanitizer and ThreadSanitizer
+// run-time libraries.
----------------
Drive-by nit: this comment doesn't explain the what this file is for.

================
Comment at: sanitizer_common/sanitizer_chainedorigindepot.h:1
@@ +1,2 @@
+//===-- sanitizer_chainedorigindepot.h --------------------------*- C++ -*-===//
+//
----------------
Drive-by nit: please split "chainedorigindepot" like we do for other lengthy filenames.

================
Comment at: sanitizer_common/sanitizer_region_allocator.h:10
@@ +9,3 @@
+//
+// This file is shared between AddressSanitizer and ThreadSanitizer
+// run-time libraries.
----------------
Ditto.

================
Comment at: sanitizer_common/sanitizer_stackdepot.h:66
@@ -59,1 +65,3 @@
 };
+
+
----------------
Nit: spare newline(s)?

http://reviews.llvm.org/D3790






More information about the llvm-commits mailing list