[PATCH] Full support for dllexport/dllimport attributes

Hans Wennborg hans at chromium.org
Thu May 15 11:51:25 PDT 2014


> Regarding handling the dll linkage in AST or Codegen, I was kind of hoping doing it in AST would help in functions such as ASTContext::DeclMustBeEmitted (but it currently doesn't).
>
> I don't have enough experience here to feel strongly either way, but I do suspect that it will become clearer which solution is best as we get further along the train of patches towards full support for class-level dllimport/dllexport.
>
>I would like to go ahead and commit this now, and am totally open to moving the linkage adjusting code if it seems like a good idea as we go forward.

Sorry, this comment was for http://reviews.llvm.org/D3772.

http://reviews.llvm.org/D1099






More information about the llvm-commits mailing list